lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 488/633] memory: omap-gpmc: Fix build error without CONFIG_OF
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit 13d029ee51da365aa9c859db0c7395129252bde8 ]

    If CONFIG_OF is n, gcc fails:

    drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings':
    omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt'

    Add gpmc_read_settings_dt() helper function, which zero the gpmc_settings
    so the caller doesn't proceed with random/invalid settings.

    Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Acked-by: Roger Quadros <rogerq@ti.com>
    Link: https://lore.kernel.org/r/20200827125316.20780-1-yuehaibing@huawei.com
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/omap-gpmc.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
    index b5055577843a2..27bc417029e11 100644
    --- a/drivers/memory/omap-gpmc.c
    +++ b/drivers/memory/omap-gpmc.c
    @@ -2274,6 +2274,10 @@ static void gpmc_probe_dt_children(struct platform_device *pdev)
    }
    }
    #else
    +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p)
    +{
    + memset(p, 0, sizeof(*p));
    +}
    static int gpmc_probe_dt(struct platform_device *pdev)
    {
    return 0;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:10    [W:4.016 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site