lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 523/633] ntb: intel: Fix memleak in intel_ntb_pci_probe
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit dbb8df5c2d27610a87b0168a8acc89d73fbfde94 ]

    The default error branch of a series of pdev_is_gen calls
    should free ndev just like what we've done in these calls.

    Fixes: 26bfe3d0b227 ("ntb: intel: Add Icelake (gen4) support for Intel NTB")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Acked-by: Dave Jiang <dave.jiang@intel.com>
    Signed-off-by: Jon Mason <jdmason@kudzu.us>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c
    index 423f9b8fbbcf5..fa561d455f7c8 100644
    --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c
    +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c
    @@ -1893,7 +1893,7 @@ static int intel_ntb_pci_probe(struct pci_dev *pdev,
    goto err_init_dev;
    } else {
    rc = -EINVAL;
    - goto err_ndev;
    + goto err_init_pci;
    }

    ndev_reset_unsafe_flags(ndev);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:10    [W:4.085 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site