lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 536/633] media: sti: Fix reference count leaks
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 6f4432bae9f2d12fc1815b5e26cc07e69bcad0df ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code, causing incorrect ref count if
    pm_runtime_put_noidle() is not called in error handling paths.
    Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/sti/hva/hva-hw.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
    index 401aaafa17109..bb13348be0832 100644
    --- a/drivers/media/platform/sti/hva/hva-hw.c
    +++ b/drivers/media/platform/sti/hva/hva-hw.c
    @@ -272,6 +272,7 @@ static unsigned long int hva_hw_get_ip_version(struct hva_dev *hva)

    if (pm_runtime_get_sync(dev) < 0) {
    dev_err(dev, "%s failed to get pm_runtime\n", HVA_PREFIX);
    + pm_runtime_put_noidle(dev);
    mutex_unlock(&hva->protect_mutex);
    return -EFAULT;
    }
    @@ -553,6 +554,7 @@ void hva_hw_dump_regs(struct hva_dev *hva, struct seq_file *s)

    if (pm_runtime_get_sync(dev) < 0) {
    seq_puts(s, "Cannot wake up IP\n");
    + pm_runtime_put_noidle(dev);
    mutex_unlock(&hva->protect_mutex);
    return;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:40    [W:2.697 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site