lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 171/757] media: stm32-dcmi: Fix a reference count leak
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 88f50a05f907d96a27a9ce3cc9e8cbb91a6f0f22 ]

    Calling pm_runtime_get_sync increments the counter even in case of
    failure, causing incorrect ref count if pm_runtime_put is not
    called in error handling paths. Thus replace the jump target
    "err_release_buffers" by "err_pm_putw".

    Fixes: 152e0bf60219 ("media: stm32-dcmi: add power saving support")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/stm32/stm32-dcmi.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
    index b8931490b83b7..fd1c41cba52fc 100644
    --- a/drivers/media/platform/stm32/stm32-dcmi.c
    +++ b/drivers/media/platform/stm32/stm32-dcmi.c
    @@ -733,7 +733,7 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)
    if (ret < 0) {
    dev_err(dcmi->dev, "%s: Failed to start streaming, cannot get sync (%d)\n",
    __func__, ret);
    - goto err_release_buffers;
    + goto err_pm_put;
    }

    ret = media_pipeline_start(&dcmi->vdev->entity, &dcmi->pipeline);
    @@ -837,8 +837,6 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)

    err_pm_put:
    pm_runtime_put(dcmi->dev);
    -
    -err_release_buffers:
    spin_lock_irq(&dcmi->irqlock);
    /*
    * Return all buffers to vb2 in QUEUED state.
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:30    [W:4.136 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site