lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 163/757] media: tc358743: initialize variable
    Date
    From: Tom Rix <trix@redhat.com>

    [ Upstream commit 274cf92d5dff5c2fec1a518078542ffe70d07646 ]

    clang static analysis flags this error

    tc358743.c:1468:9: warning: Branch condition evaluates
    to a garbage value
    return handled ? IRQ_HANDLED : IRQ_NONE;
    ^~~~~~~
    handled should be initialized to false.

    Fixes: d747b806abf4 ("[media] tc358743: add direct interrupt handling")
    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/tc358743.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
    index dbbab75f135ec..211caade9f998 100644
    --- a/drivers/media/i2c/tc358743.c
    +++ b/drivers/media/i2c/tc358743.c
    @@ -1461,7 +1461,7 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
    static irqreturn_t tc358743_irq_handler(int irq, void *dev_id)
    {
    struct tc358743_state *state = dev_id;
    - bool handled;
    + bool handled = false;

    tc358743_isr(&state->sd, 0, &handled);

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:29    [W:2.421 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site