lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 494/633] soc: qcom: pdr: Fixup array type of get_domain_list_resp message
    Date
    From: Sibi Sankar <sibis@codeaurora.org>

    [ Upstream commit 7a366707bb6a93baeb1a9ef46c4b9c875e0132d6 ]

    The array type of get_domain_list_resp is incorrectly marked as NO_ARRAY.
    Due to which the following error was observed when using pdr helpers with
    the downstream proprietary pd-mapper. Fix this up by marking it as
    VAR_LEN_ARRAY instead.

    Err logs:
    qmi_decode_struct_elem: Fault in decoding: dl(2), db(27), tl(160), i(1), el(1)
    failed to decode incoming message
    PDR: tms/servreg get domain list txn wait failed: -14
    PDR: service lookup for tms/servreg failed: -14

    Tested-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
    Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")
    Reported-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
    Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
    Link: https://lore.kernel.org/r/20200914145807.1224-1-sibis@codeaurora.org
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/pdr_internal.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/pdr_internal.h b/drivers/soc/qcom/pdr_internal.h
    index 15b5002e4127b..ab9ae8cdfa54c 100644
    --- a/drivers/soc/qcom/pdr_internal.h
    +++ b/drivers/soc/qcom/pdr_internal.h
    @@ -185,7 +185,7 @@ struct qmi_elem_info servreg_get_domain_list_resp_ei[] = {
    .data_type = QMI_STRUCT,
    .elem_len = SERVREG_DOMAIN_LIST_LENGTH,
    .elem_size = sizeof(struct servreg_location_entry),
    - .array_type = NO_ARRAY,
    + .array_type = VAR_LEN_ARRAY,
    .tlv_type = 0x12,
    .offset = offsetof(struct servreg_get_domain_list_resp,
    domain_list),
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:17    [W:2.319 / U:0.836 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site