lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 408/633] um: vector: Use GFP_ATOMIC under spin lock
    Date
    From: Tiezhu Yang <yangtiezhu@loongson.cn>

    [ Upstream commit e4e721fe4ccb504a29d1e8d4047667557281d932 ]

    Use GFP_ATOMIC instead of GFP_KERNEL under spin lock to fix possible
    sleep-in-atomic-context bugs.

    Fixes: 9807019a62dc ("um: Loadable BPF "Firmware" for vector drivers")
    Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
    Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/um/drivers/vector_kern.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
    index 8735c468230a5..555203e3e7b45 100644
    --- a/arch/um/drivers/vector_kern.c
    +++ b/arch/um/drivers/vector_kern.c
    @@ -1403,7 +1403,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
    kfree(vp->bpf->filter);
    vp->bpf->filter = NULL;
    } else {
    - vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_KERNEL);
    + vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_ATOMIC);
    if (vp->bpf == NULL) {
    netdev_err(dev, "failed to allocate memory for firmware\n");
    goto flash_fail;
    @@ -1415,7 +1415,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
    if (request_firmware(&fw, efl->data, &vdevice->pdev.dev))
    goto flash_fail;

    - vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_KERNEL);
    + vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_ATOMIC);
    if (!vp->bpf->filter)
    goto free_buffer;

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:14    [W:4.154 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site