lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 279/633] iomap: Use kzalloc to allocate iomap_page
    Date
    From: Matthew Wilcox (Oracle) <willy@infradead.org>

    [ Upstream commit a6901d4d148dcbad7efb3174afbdf68c995618c2 ]

    We can skip most of the initialisation, although spinlocks still
    need explicit initialisation as architectures may use a non-zero
    value to indicate unlocked. The comment is no longer useful as
    attach_page_private() handles the refcount now.

    Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/iomap/buffered-io.c | 10 +---------
    1 file changed, 1 insertion(+), 9 deletions(-)

    diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
    index 897ab9a26a74c..b115e7d47fcec 100644
    --- a/fs/iomap/buffered-io.c
    +++ b/fs/iomap/buffered-io.c
    @@ -49,16 +49,8 @@ iomap_page_create(struct inode *inode, struct page *page)
    if (iop || i_blocksize(inode) == PAGE_SIZE)
    return iop;

    - iop = kmalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL);
    - atomic_set(&iop->read_count, 0);
    - atomic_set(&iop->write_count, 0);
    + iop = kzalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL);
    spin_lock_init(&iop->uptodate_lock);
    - bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE);
    -
    - /*
    - * migrate_page_move_mapping() assumes that pages with private data have
    - * their count elevated by 1.
    - */
    attach_page_private(page, iop);
    return iop;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:13    [W:4.401 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site