Messages in this thread Patch in this message | | | Date | Tue, 27 Oct 2020 08:54:52 +0100 | From | "" <> | Subject | Re: [PATCH] dma: Per-NUMA-node CMA should depend on NUMA |
| |
On Mon, Oct 26, 2020 at 08:07:43PM +0000, Song Bao Hua (Barry Song) wrote: > > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > > index c99de4a21458..964b74c9b7e3 100644 > > --- a/kernel/dma/Kconfig > > +++ b/kernel/dma/Kconfig > > @@ -125,7 +125,8 @@ if DMA_CMA > > > > config DMA_PERNUMA_CMA > > bool "Enable separate DMA Contiguous Memory Area for each NUMA > > Node" > > - default NUMA && ARM64 > > + depends on NUMA > > + default ARM64 > > On the other hand, at this moment, only ARM64 is calling the init code > to get per_numa cma. Do we need to > depends on NUMA && ARM64 ? > so that this is not enabled by non-arm64?
I actually hate having arch symbols in common code. A new ARCH_HAS_DMA_PERNUMA_CMA, only selected by arm64 for now would be more clean I think.
| |