lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 387/408] Bluetooth: btusb: Fix memleak in btusb_mtk_submit_wmt_recv_urb
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit d33fe77bdf75806d785dabf90d21d962122e5296 ]

    When kmalloc() on buf fails, urb should be freed just like
    when kmalloc() on dr fails.

    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bluetooth/btusb.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
    index f3f0529564da0..b326eeddaadf0 100644
    --- a/drivers/bluetooth/btusb.c
    +++ b/drivers/bluetooth/btusb.c
    @@ -2664,6 +2664,7 @@ static int btusb_mtk_submit_wmt_recv_urb(struct hci_dev *hdev)
    buf = kmalloc(size, GFP_KERNEL);
    if (!buf) {
    kfree(dr);
    + usb_free_urb(urb);
    return -ENOMEM;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:10    [W:3.158 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site