lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 189/633] drm/crc-debugfs: Fix memleak in crc_control_write
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit f7ec68b341dbd5da13d4c65ce444dcd605f1c42e ]

    When verify_crc_source() fails, source needs to be freed.
    However, current code is returning directly and ends up
    leaking memory.

    Fixes: d5cc15a0c66e ("drm: crc: Introduce verify_crc_source callback")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    [danvet: change Fixes: tag per Laurent's review]
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200819082228.26847-1-dinghao.liu@zju.edu.cn
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/drm_debugfs_crc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
    index 5d67a41f7c3a8..3dd70d813f694 100644
    --- a/drivers/gpu/drm/drm_debugfs_crc.c
    +++ b/drivers/gpu/drm/drm_debugfs_crc.c
    @@ -144,8 +144,10 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
    source[len - 1] = '\0';

    ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt);
    - if (ret)
    + if (ret) {
    + kfree(source);
    return ret;
    + }

    spin_lock_irq(&crc->lock);

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:10    [W:3.003 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site