lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 176/633] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()
    Date
    From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

    [ Upstream commit bbf2d06a9d767718bfe6028d6288c03edb98554a ]

    In the case of a failed retry, a positive value EIO is returned here. I
    think this is a typo error. It is necessary to return an error value.

    [mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up
    to be consistent]

    Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com
    Fixes: 0691094ff3f2 ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
    Cc: Quinn Tran <quinn.tran@cavium.com>
    Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_target.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
    index 90289162dbd4c..a034e9caa2997 100644
    --- a/drivers/scsi/qla2xxx/qla_target.c
    +++ b/drivers/scsi/qla2xxx/qla_target.c
    @@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha,
    /* found existing exchange */
    qpair->retry_term_cnt++;
    if (qpair->retry_term_cnt >= 5) {
    - rc = EIO;
    + rc = -EIO;
    qpair->retry_term_cnt = 0;
    ql_log(ql_log_warn, vha, 0xffff,
    "Unable to send ABTS Respond. Dumping firmware.\n");
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:10    [W:3.087 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site