lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 325/633] powerpc/pseries: Fix missing of_node_put() in rng_init()
    Date
    From: Nicholas Mc Guire <hofrat@osadl.org>

    [ Upstream commit 67c3e59443f5fc77be39e2ce0db75fbfa78c7965 ]

    The call to of_find_compatible_node() returns a node pointer with
    refcount incremented thus it must be explicitly decremented here
    before returning.

    Fixes: a489043f4626 ("powerpc/pseries: Implement arch_get_random_long() based on H_RANDOM")
    Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/1530522496-14816-1-git-send-email-hofrat@osadl.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/pseries/rng.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/platforms/pseries/rng.c b/arch/powerpc/platforms/pseries/rng.c
    index bbb97169bf63e..6268545947b83 100644
    --- a/arch/powerpc/platforms/pseries/rng.c
    +++ b/arch/powerpc/platforms/pseries/rng.c
    @@ -36,6 +36,7 @@ static __init int rng_init(void)

    ppc_md.get_random_seed = pseries_get_random_long;

    + of_node_put(dn);
    return 0;
    }
    machine_subsys_initcall(pseries, rng_init);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:08    [W:4.044 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site