Messages in this thread | | | Subject | Re: [External] Re: [PATCH] [RFC] Documentation: Add documentation for new platform_profile sysfs attribute | From | Mark Pearson <> | Date | Tue, 27 Oct 2020 11:01:04 -0400 |
| |
On 27/10/2020 09:41, Hans de Goede wrote: > Hi Mark, > > On 10/27/20 1:28 PM, Mark Pearson wrote: >> Hi Elia >> >> On 27/10/2020 05:19, Elia Devito wrote: >>> Hi to all, >>> >>> In data martedì 27 ottobre 2020 08:54:44 CET, Hans de Goede ha scritto: <snip> >>> >>> This look good, >>> only thing is that hp-wmi driver need a cool profile (Emphasises the computer >>> cool to touch), if you can add it would be perfect. >>> >>> Regards >>> Elia >>> >>> >>> >> Is low-power is different to cool? I figured low-power was going to be cool so combined them. >> I could call it low-power-cool if that helps? It seems a little clunky but not too bad. I'm sure the user space folks can put sunglasses on it or something ;) > > IIRC we already had this discussion, cool means cool-to-touch, so could be done by > e.g. extra aggressive ramping up of the fans, so this is not necessarily the same > as low-power. > > Yes this is all somewhat confusing. Luckily (for us kernel folks) we have already > sorta decided to just use the profile-names from the vendors more or less as is and > leave figuring this out further to userspace. > > The reason to use the enum + try to have a fixed list of choices is to try and > limit the proliferation of profile-names to keep things somewhat manageable. > > But as I discussed previously with Elia (*) we really need all 3 of low-power > cool and quiet. > > Regards, > > Hans > > > > *) I was coming at this discussion from the same angle you (Mark) are > OK, I can add a cool option.
I'll get that out later today (unless Elia corrects me :))
Thanks all Mark
| |