lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 244/633] net: dsa: rtl8366: Skip PVID setting if not requested
    Date
    From: Linus Walleij <linus.walleij@linaro.org>

    [ Upstream commit 3dfe8dde093a07e82fa472c0f8c29a7f6a2006a5 ]

    We go to lengths to determine whether the PVID should be set
    for this port or not, and then fail to take it into account.
    Fix this oversight.

    Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/dsa/rtl8366.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
    index b941d45edd641..49c626a336803 100644
    --- a/drivers/net/dsa/rtl8366.c
    +++ b/drivers/net/dsa/rtl8366.c
    @@ -436,6 +436,9 @@ void rtl8366_vlan_add(struct dsa_switch *ds, int port,
    "failed to set up VLAN %04x",
    vid);

    + if (!pvid)
    + continue;
    +
    ret = rtl8366_set_pvid(smi, port, vid);
    if (ret)
    dev_err(smi->dev,
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:03    [W:4.450 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site