lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 254/408] mm/page_owner: change split_page_owner to take a count
    Date
    From: Matthew Wilcox (Oracle) <willy@infradead.org>

    [ Upstream commit 8fb156c9ee2db94f7127c930c89917634a1a9f56 ]

    The implementation of split_page_owner() prefers a count rather than the
    old order of the page. When we support a variable size THP, we won't
    have the order at this point, but we will have the number of pages.
    So change the interface to what the caller and callee would prefer.

    Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Reviewed-by: SeongJae Park <sjpark@amazon.de>
    Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Cc: Huang Ying <ying.huang@intel.com>
    Link: https://lkml.kernel.org/r/20200908195539.25896-4-willy@infradead.org
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/page_owner.h | 6 +++---
    mm/huge_memory.c | 2 +-
    mm/page_alloc.c | 2 +-
    mm/page_owner.c | 4 ++--
    4 files changed, 7 insertions(+), 7 deletions(-)

    diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h
    index 8679ccd722e89..3468794f83d23 100644
    --- a/include/linux/page_owner.h
    +++ b/include/linux/page_owner.h
    @@ -11,7 +11,7 @@ extern struct page_ext_operations page_owner_ops;
    extern void __reset_page_owner(struct page *page, unsigned int order);
    extern void __set_page_owner(struct page *page,
    unsigned int order, gfp_t gfp_mask);
    -extern void __split_page_owner(struct page *page, unsigned int order);
    +extern void __split_page_owner(struct page *page, unsigned int nr);
    extern void __copy_page_owner(struct page *oldpage, struct page *newpage);
    extern void __set_page_owner_migrate_reason(struct page *page, int reason);
    extern void __dump_page_owner(struct page *page);
    @@ -31,10 +31,10 @@ static inline void set_page_owner(struct page *page,
    __set_page_owner(page, order, gfp_mask);
    }

    -static inline void split_page_owner(struct page *page, unsigned int order)
    +static inline void split_page_owner(struct page *page, unsigned int nr)
    {
    if (static_branch_unlikely(&page_owner_inited))
    - __split_page_owner(page, order);
    + __split_page_owner(page, nr);
    }
    static inline void copy_page_owner(struct page *oldpage, struct page *newpage)
    {
    diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    index 873de55d93fb2..9295d9d70681e 100644
    --- a/mm/huge_memory.c
    +++ b/mm/huge_memory.c
    @@ -2569,7 +2569,7 @@ static void __split_huge_page(struct page *page, struct list_head *list,

    ClearPageCompound(head);

    - split_page_owner(head, HPAGE_PMD_ORDER);
    + split_page_owner(head, HPAGE_PMD_NR);

    /* See comment in __split_huge_page_tail() */
    if (PageAnon(head)) {
    diff --git a/mm/page_alloc.c b/mm/page_alloc.c
    index 2640f67410044..c20e664866c33 100644
    --- a/mm/page_alloc.c
    +++ b/mm/page_alloc.c
    @@ -3130,7 +3130,7 @@ void split_page(struct page *page, unsigned int order)

    for (i = 1; i < (1 << order); i++)
    set_page_refcounted(page + i);
    - split_page_owner(page, order);
    + split_page_owner(page, 1 << order);
    }
    EXPORT_SYMBOL_GPL(split_page);

    diff --git a/mm/page_owner.c b/mm/page_owner.c
    index 18ecde9f45b24..83d08943bcdee 100644
    --- a/mm/page_owner.c
    +++ b/mm/page_owner.c
    @@ -204,7 +204,7 @@ void __set_page_owner_migrate_reason(struct page *page, int reason)
    page_owner->last_migrate_reason = reason;
    }

    -void __split_page_owner(struct page *page, unsigned int order)
    +void __split_page_owner(struct page *page, unsigned int nr)
    {
    int i;
    struct page_ext *page_ext = lookup_page_ext(page);
    @@ -213,7 +213,7 @@ void __split_page_owner(struct page *page, unsigned int order)
    if (unlikely(!page_ext))
    return;

    - for (i = 0; i < (1 << order); i++) {
    + for (i = 0; i < nr; i++) {
    page_owner = get_page_owner(page_ext);
    page_owner->order = 0;
    page_ext = page_ext_next(page_ext);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:54    [W:3.318 / U:0.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site