lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 037/633] chelsio/chtls: fix writing freed memory
    Date
    From: Vinay Kumar Yadav <vinay.yadav@chelsio.com>

    [ Upstream commit da1a039bcf293e4699d413c9f65d975da2d7c0bd ]

    When chtls_sock *csk is freed, same memory can be allocated
    to different csk in chtls_sock_create().
    csk->cdev = NULL; statement might ends up modifying wrong
    csk, eventually causing kernel panic.
    removing (csk->cdev = NULL) statement as it is not required.

    Fixes: 3a0a97838923 ("crypto/chtls: Fix chtls crash in connection cleanup")
    Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/chelsio/chtls/chtls_cm.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/crypto/chelsio/chtls/chtls_cm.c
    +++ b/drivers/crypto/chelsio/chtls/chtls_cm.c
    @@ -483,7 +483,6 @@ void chtls_destroy_sock(struct sock *sk)
    chtls_purge_write_queue(sk);
    free_tls_keyid(sk);
    kref_put(&csk->kref, chtls_sock_release);
    - csk->cdev = NULL;
    if (sk->sk_family == AF_INET)
    sk->sk_prot = &tcp_prot;
    #if IS_ENABLED(CONFIG_IPV6)

    \
     
     \ /
      Last update: 2020-10-27 15:50    [W:4.082 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site