Messages in this thread Patch in this message | | | Date | Tue, 27 Oct 2020 22:45:29 +0800 | From | Hui Su <> | Subject | [PATCH v2] mm/oom_kill.c: remove the unmatched comments |
| |
is_dump_unreclaim_slabs() just check whether nr_unreclaimable slabs amount is greater than user memory, not match witch comment.
So delete the comment, and rename it to should_dump_unreclaim_slabs().
Signed-off-by: Hui Su <sh_def@163.com> --- mm/oom_kill.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 8b84661a6410..d181e24d7193 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -170,11 +170,7 @@ static bool oom_unkillable_task(struct task_struct *p) return false; } -/* - * Print out unreclaimble slabs info when unreclaimable slabs amount is greater - * than all user memory (LRU pages) - */ -static bool is_dump_unreclaim_slabs(void) +static bool should_dump_unreclaim_slabs(void) { unsigned long nr_lru; @@ -463,7 +459,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p) mem_cgroup_print_oom_meminfo(oc->memcg); else { show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask); - if (is_dump_unreclaim_slabs()) + if (should_dump_unreclaim_slabs()) dump_unreclaimable_slab(); } if (sysctl_oom_dump_tasks) -- 2.25.1
| |