lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 165/408] slimbus: core: check get_addr before removing laddr ida
    Date
    From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

    [ Upstream commit f97769fde678e111a1b7b165b380d8a3dfe54f4e ]

    logical address can be either assigned by the SLIMBus controller or the core.
    Core uses IDA in cases where get_addr callback is not provided by the
    controller.
    Core already has this check while allocating IDR, however during absence
    reporting this is not checked. This patch fixes this issue.

    Fixes: 46a2bb5a7f7e ("slimbus: core: Add slim controllers support")
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Link: https://lore.kernel.org/r/20200925095520.27316-2-srinivas.kandagatla@linaro.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/slimbus/core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
    index 63ee96eb58c68..42a233fc5dc6c 100644
    --- a/drivers/slimbus/core.c
    +++ b/drivers/slimbus/core.c
    @@ -327,8 +327,8 @@ void slim_report_absent(struct slim_device *sbdev)
    mutex_lock(&ctrl->lock);
    sbdev->is_laddr_valid = false;
    mutex_unlock(&ctrl->lock);
    -
    - ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr);
    + if (!ctrl->get_laddr)
    + ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr);
    slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_DOWN);
    }
    EXPORT_SYMBOL_GPL(slim_report_absent);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:36    [W:4.042 / U:1.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site