lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 104/408] drm/vkms: fix xrgb on compute crc
    Date
    From: Melissa Wen <melissa.srw@gmail.com>

    [ Upstream commit 0986191186128b10b6bbfa5220fc587ed5725e49 ]

    The previous memset operation was not correctly zeroing the alpha
    channel to compute the crc, and as a result, the IGT subtest
    kms_cursor_crc/pipe-A-cursor-alpha-transparent fails.

    Fixes: db7f419c06d7c ("drm/vkms: Compute CRC with Cursor Plane")

    Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200730202524.5upzuh4irboru7my@smtp.gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
    index d5585695c64d1..45d6ebbdbdb22 100644
    --- a/drivers/gpu/drm/vkms/vkms_composer.c
    +++ b/drivers/gpu/drm/vkms/vkms_composer.c
    @@ -33,7 +33,7 @@ static uint32_t compute_crc(void *vaddr_out, struct vkms_composer *composer)
    + (i * composer->pitch)
    + (j * composer->cpp);
    /* XRGB format ignores Alpha channel */
    - memset(vaddr_out + src_offset + 24, 0, 8);
    + bitmap_clear(vaddr_out + src_offset, 24, 8);
    crc = crc32_le(crc, vaddr_out + src_offset,
    sizeof(u32));
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:34    [W:2.994 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site