Messages in this thread | | | Date | Mon, 26 Oct 2020 17:24:31 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392 |
| |
On Mon, Oct 26, 2020 at 06:18:35PM +0100, Fabien Parent wrote: > On Mon, Oct 26, 2020 at 1:13 PM Mark Brown <broonie@kernel.org> wrote:
> > On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote:
> > > +Required properties: > > > +- compatible: "mediatek,mt6392-regulator"
> > This is no longer used by the driver, should be unneeded and therefore > > should be removed.
> It is not used by the driver but it will be used by the MFD driver [0] > like this: > static const struct mfd_cell mt6392_devs[] = { > { > [snip] > }, { > [snip] > }, { > .name = "mt6392-regulator", > .of_compatible = "mediatek,mt6392-regulator"
This is still unneeded, it's just a reflection of Linux implementation details and should be removed. The MFD can just register the child without supplying a compatible and things will continue to work just as well. [unhandled content-type:application/pgp-signature] | |