lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] dmaengine: ti: k3-udma: fix -Wenum-conversion warning
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    gcc warns about a mismatch argument type when passing
    'false' into a function that expects an enum:

    drivers/dma/ti/k3-udma-private.c: In function 'xudma_tchan_get':
    drivers/dma/ti/k3-udma-private.c:86:34: warning: implicit conversion from 'enum <anonymous>' to 'enum udma_tp_level' [-Wenum-conversion]
    86 | return __udma_reserve_##res(ud, false, id); \
    | ^~~~~
    drivers/dma/ti/k3-udma-private.c:95:1: note: in expansion of macro 'XUDMA_GET_PUT_RESOURCE'
    95 | XUDMA_GET_PUT_RESOURCE(tchan);
    | ^~~~~~~~~~~~~~~~~~~~~~

    In this case, false has the same numerical value as
    UDMA_TP_NORMAL, so passing that is most likely the correct
    way to avoid the warning without changing the behavior.

    Fixes: d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/dma/ti/k3-udma-private.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/dma/ti/k3-udma-private.c b/drivers/dma/ti/k3-udma-private.c
    index aa24e554f7b4..8563a392f30b 100644
    --- a/drivers/dma/ti/k3-udma-private.c
    +++ b/drivers/dma/ti/k3-udma-private.c
    @@ -83,7 +83,7 @@ EXPORT_SYMBOL(xudma_rflow_is_gp);
    #define XUDMA_GET_PUT_RESOURCE(res) \
    struct udma_##res *xudma_##res##_get(struct udma_dev *ud, int id) \
    { \
    - return __udma_reserve_##res(ud, false, id); \
    + return __udma_reserve_##res(ud, UDMA_TP_NORMAL, id); \
    } \
    EXPORT_SYMBOL(xudma_##res##_get); \
    \
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-10-26 17:03    [W:2.496 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site