Messages in this thread | | | From | "Limonciello, Mario" <> | Subject | RE: [PATCH v6] Introduce support for Systems Management Driver over WMI for Dell Systems | Date | Mon, 26 Oct 2020 15:39:34 +0000 |
| |
> This was present in previous versions too, but I just noticed this are you > sure that using > .string.pointer is correct here? That seems wrong since the pointer gets > allocated by > the Linux ACPI core, so it is not under influence of the AML code? > > I think you want / need to use ".integer.value" here ? > > And maybe first do a type check, e.g.: > > if (obj->package.elements[CURRENT_VAL].type != ACPI_TYPE_INTEGER) { > ret = -EINVAL; > goto out; > } > > Adding this type check will also show if I'm right that you should use > .integer.value ... > > ret = snprintf(buf, PAGE_SIZE, "%lld\n", obj-
We'll need to double check this, but I'm pretty sure the firmware outputs everything as a string.
| |