lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 10/10] pwm: Add Raspberry Pi Firmware based PWM bus
From
Date
Hi Andy, thanks for the review!

On Thu, 2020-10-22 at 21:53 +0300, Andy Shevchenko wrote:
> On Thu, Oct 22, 2020 at 9:05 PM Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> > Adds support to control the PWM bus available in official Raspberry Pi
> > PoE HAT. Only RPi's co-processor has access to it, so commands have to
> > be sent through RPi's firmware mailbox interface.
> > drivers/pwm/pwm-raspberrypi.c | 221 ++++++++++++++++++++++++++++++++++
>
> Name is completely confusing.
> Please, make it unique enough to understand that this is exactly the
> device it serves for.
>
> For example, pwm-rpi-poe is better.

Sounds reasonable, I'll change that.

>
> ...
>
> > + * - Only normal polarity
>
> Can't it be emulated? Isn't it 100% - duty cycle % ?

I guess it can, OTOH given the rather specific use case, I doubt it'll be
worth the effort.

> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/pwm.h>
>
> ...
>
> > + ret = rpi_firmware_property(firmware, RPI_FIRMWARE_SET_POE_HAT_VAL,
> > + &msg, sizeof(msg));
> > + if (ret)
> > + return ret;
> > + else if (msg.ret)
>
> Redundant 'else'

Noted.

> > + firmware_node = of_get_parent(dev->of_node);
> > + if (!firmware_node) {
> > + dev_err(dev, "Missing firmware node\n");
> > + return -ENOENT;
> > + }
> > +
> > + firmware = rpi_firmware_get(firmware_node);
> > + of_node_put(firmware_node);
> > + if (!firmware)
> > + return -EPROBE_DEFER;
>
> Looks like a hack.

This is the pattern we've been using on all firmware dependent devices so far.
Feel free to suggest a better way, I'll be happy to look into it.

>
> ...
>
> > + ret = pwmchip_remove(&rpipwm->chip);
> > + if (!ret)
> > + rpi_firmware_put(rpipwm->firmware);
> > +
> > + return ret;
>
> Can't you use the usual pattern?

Yes of course. Don't know why I went this way.

Regards,
Nicolas

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-10-26 15:05    [W:0.057 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site