lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] usb: cdns3: Variable 'length' set but not used
Date
Hi Peter,

A gentle ping.

I assume that you should add this and the rest overdue cdsn3 patches as first to you ci-for-usb-next branch.
Am I right?

Pawel

>Patch removes not used variable 'length' from
>cdns3_wa2_descmiss_copy_data function.
>
>Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>Acked-by: Roger Quadros <rogerq@ti.com>
>---
>Changelog:
>v3
>- added "Acked-by" tag.
>v2
>- added "Fixes" tag.
>
> drivers/usb/cdns3/gadget.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
>index 6e7b70a2e352..692acf7b9b14 100644
>--- a/drivers/usb/cdns3/gadget.c
>+++ b/drivers/usb/cdns3/gadget.c
>@@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>
> while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
> int chunk_end;
>- int length;
>
> descmiss_priv_req =
> cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
>@@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
> break;
>
> chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
>- length = request->actual + descmiss_req->actual;
> request->status = descmiss_req->status;
> __cdns3_descmiss_copy_data(request, descmiss_req);
> list_del_init(&descmiss_priv_req->list);
>--
>2.17.1

\
 
 \ /
  Last update: 2020-10-26 11:14    [W:0.077 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site