lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next 07/11] rtw88: remove extraneous 'const' qualifier
    On Mon, Oct 26, 2020 at 10:29:54PM +0100, Arnd Bergmann wrote:
    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > clang -Wextra warns about functions returning a 'const' integer:
    >
    > drivers/net/wireless/realtek/rtw88/rtw8822b.c:90:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
    > static const u8 rtw8822b_get_swing_index(struct rtw_dev *rtwdev)
    >
    > Remove the extra qualifier here.
    >
    > Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>

    > ---
    > drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
    > index 22d0dd640ac9..b420eb914879 100644
    > --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
    > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
    > @@ -87,7 +87,7 @@ static const u32 rtw8822b_txscale_tbl[RTW_TXSCALE_SIZE] = {
    > 0x2d3, 0x2fe, 0x32b, 0x35c, 0x38e, 0x3c4, 0x3fe
    > };
    >
    > -static const u8 rtw8822b_get_swing_index(struct rtw_dev *rtwdev)
    > +static u8 rtw8822b_get_swing_index(struct rtw_dev *rtwdev)
    > {
    > u8 i = 0;
    > u32 swing, table_value;
    > --
    > 2.27.0
    >

    \
     
     \ /
      Last update: 2020-10-27 02:49    [W:5.382 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site