lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.9 111/147] clk: ti: clockdomain: fix static checker warning
    Date
    From: Tero Kristo <t-kristo@ti.com>

    [ Upstream commit b7a7943fe291b983b104bcbd2f16e8e896f56590 ]

    Fix a memory leak induced by not calling clk_put after doing of_clk_get.

    Reported-by: Dan Murphy <dmurphy@ti.com>
    Signed-off-by: Tero Kristo <t-kristo@ti.com>
    Link: https://lore.kernel.org/r/20200907082600.454-3-t-kristo@ti.com
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/ti/clockdomain.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
    index ee56306f79d5f..700b7f44f6716 100644
    --- a/drivers/clk/ti/clockdomain.c
    +++ b/drivers/clk/ti/clockdomain.c
    @@ -148,10 +148,12 @@ static void __init of_ti_clockdomain_setup(struct device_node *node)
    if (!omap2_clk_is_hw_omap(clk_hw)) {
    pr_warn("can't setup clkdm for basic clk %s\n",
    __clk_get_name(clk));
    + clk_put(clk);
    continue;
    }
    to_clk_hw_omap(clk_hw)->clkdm_name = clkdm_name;
    omap2_init_clk_clkdm(clk_hw);
    + clk_put(clk);
    }
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-10-27 01:39    [W:4.129 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site