Messages in this thread | | | Date | Mon, 26 Oct 2020 08:44:10 +0000 | From | Marc Zyngier <> | Subject | Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt |
| |
On 2020-10-26 08:01, Biwen Li wrote: > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > Add an new IRQ chip declaration for LS1043A and LS1088A > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA
Three things: - This commit message doesn't describe the bit_reverse change - Please add a cover letter - Sending the same series again after 4 days is not OK, specially when the initial one was during the merge window.
Thanks,
M.
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > Signed-off-by: Biwen Li <biwen.li@nxp.com> > --- > drivers/irqchip/irq-ls-extirq.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/irqchip/irq-ls-extirq.c > b/drivers/irqchip/irq-ls-extirq.c > index 4d1179fed77c..564e6de0bd8e 100644 > --- a/drivers/irqchip/irq-ls-extirq.c > +++ b/drivers/irqchip/irq-ls-extirq.c > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > +// Copyright 2019-2020 NXP > > #define pr_fmt(fmt) "irq-ls-extirq: " fmt > > @@ -183,6 +184,9 @@ ls_extirq_of_init(struct device_node *node, struct > device_node *parent) > priv->bit_reverse = (revcr != 0); > } > > + if (of_device_is_compatible(node, "fsl,ls1043a-extirq")) > + priv->bit_reverse = true; > + > domain = irq_domain_add_hierarchy(parent_domain, 0, priv->nirq, node, > &extirq_domain_ops, priv); > if (!domain) > @@ -195,3 +199,5 @@ ls_extirq_of_init(struct device_node *node, struct > device_node *parent) > } > > IRQCHIP_DECLARE(ls1021a_extirq, "fsl,ls1021a-extirq", > ls_extirq_of_init); > +IRQCHIP_DECLARE(ls1043a_extirq, "fsl,ls1043a-extirq", > ls_extirq_of_init); > +IRQCHIP_DECLARE(ls1088a_extirq, "fsl,ls1088a-extirq", > ls_extirq_of_init);
-- Jazz is not dead. It just smells funny...
| |