lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 80/80] nvme-rdma: fix crash when connect rejected
    Date
    From: Chao Leng <lengchao@huawei.com>

    [ Upstream commit 43efdb8e870ee0f58633fd579aa5b5185bf5d39e ]

    A crash can happened when a connect is rejected. The host establishes
    the connection after received ConnectReply, and then continues to send
    the fabrics Connect command. If the controller does not receive the
    ReadyToUse capsule, host may receive a ConnectReject reply.

    Call nvme_rdma_destroy_queue_ib after the host received the
    RDMA_CM_EVENT_REJECTED event. Then when the fabrics Connect command
    times out, nvme_rdma_timeout calls nvme_rdma_complete_rq to fail the
    request. A crash happenes due to use after free in
    nvme_rdma_complete_rq.

    nvme_rdma_destroy_queue_ib is redundant when handling the
    RDMA_CM_EVENT_REJECTED event as nvme_rdma_destroy_queue_ib is already
    called in connection failure handler.

    Signed-off-by: Chao Leng <lengchao@huawei.com>
    Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvme/host/rdma.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
    index abe4fe496d05c..a41ee9feab8e7 100644
    --- a/drivers/nvme/host/rdma.c
    +++ b/drivers/nvme/host/rdma.c
    @@ -1679,7 +1679,6 @@ static int nvme_rdma_cm_handler(struct rdma_cm_id *cm_id,
    complete(&queue->cm_done);
    return 0;
    case RDMA_CM_EVENT_REJECTED:
    - nvme_rdma_destroy_queue_ib(queue);
    cm_error = nvme_rdma_conn_rejected(queue, ev);
    break;
    case RDMA_CM_EVENT_ROUTE_ERROR:
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-10-27 01:00    [W:4.575 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site