lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")
    On Mon, Oct 26, 2020 at 12:36:52PM -0700, Guenter Roeck wrote:
    > On Wed, Oct 21, 2020 at 07:36:07PM -0700, Joe Perches wrote:
    > > Use a more generic form for __section that requires quotes to avoid
    > > complications with clang and gcc differences.
    > >
    > > Remove the quote operator # from compiler_attributes.h __section macro.
    > >
    > > Convert all unquoted __section(foo) uses to quoted __section("foo").
    > > Also convert __attribute__((section("foo"))) uses to __section("foo")
    > > even if the __attribute__ has multiple list entry forms.
    > >
    > > Conversion done using a script:
    > >
    > > Link: https://lore.kernel.org/lkml/75393e5ddc272dc7403de74d645e6c6e0f4e70eb.camel@perches.com/2-convert_section.pl
    > >
    > > Signed-off-by: Joe Perches <joe@perches.com>
    > > Reviewed-by: Nick Desaulniers <ndesaulniers@gooogle.com>
    > > Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
    >
    > s390 (all builds):
    >
    > Error log:
    > error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
    > make[2]: *** [arch/s390/boot/section_cmp.boot.preserved.data] Error 1
    > make[2]: *** Waiting for unfinished jobs....
    > error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
    > make[2]: *** [arch/s390/boot/section_cmp.boot.data] Error 1
    > make[1]: *** [bzImage] Error 2
    > make[1]: *** Waiting for unfinished jobs....
    > make: *** [__sub-make] Error 2
    >
    > Reverting this patch fixes the problem.
    >
    > Guenter
    >

    Seems like this should be fixed by commit 8e90b4b1305a ("s390: correct
    __bootdata / __bootdata_preserved macros").

    Cheers,
    Nathan

    \
     
     \ /
      Last update: 2020-10-26 20:45    [W:3.197 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site