Messages in this thread | | | Date | Sat, 24 Oct 2020 19:17:05 +0200 | From | Andrew Lunn <> | Subject | Re: [RFC net-next 0/5] net: phy: add support for shared interrupts |
| |
> - Every PHY driver gains a .handle_interrupt() implementation that, for > the most part, would look like below: > > irq_status = phy_read(phydev, INTR_STATUS); > if (irq_status < 0) { > phy_error(phydev); > return IRQ_NONE; > } > > if (irq_status == 0) > return IRQ_NONE; > > phy_trigger_machine(phydev); > > return IRQ_HANDLED;
Hi Ioana
It looks like phy_trigger_machine(phydev) could be left in the core, phy_interrupt(). It just needs to look at the return code, IRQ_HANDLED means trigger the state machine.
Andrew
| |