Messages in this thread | | | From | Arun KS <> | Date | Fri, 23 Oct 2020 19:51:45 +0530 | Subject | Re: [PATCH] pinctrl: msm: Use dynamic GPIO numbering |
| |
On Mon, Jan 29, 2018 at 8:30 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > The base of the TLMM gpiochip should not be statically defined as 0, fix > this to not artificially restrict the existence of multiple pinctrl-msm > devices.
Can someone please provide the details why this is needed for pinctrl-msm. Is there any msm-chipset using multiple tlmm devices? I m only concerned because, after this change, the use of gpio number from user space has become a little difficult. Can we merge the patch from Timur to maintain the past behavior when multiple tlmm devices are not present, which is most likely the case?
static int base = 0;
chip->base = base; base = -1;
Regards, Arun
> > Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver") > Reported-by: Timur Tabi <timur@codeaurora.org> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 495432f3341b..95e5c5ea40af 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -818,7 +818,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > return -EINVAL; > > chip = &pctrl->chip; > - chip->base = 0; > + chip->base = -1; > chip->ngpio = ngpio; > chip->label = dev_name(pctrl->dev); > chip->parent = pctrl->dev; > -- > 2.15.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |