Messages in this thread | | | Date | Fri, 23 Oct 2020 13:36:28 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization |
| |
On Fri, 23 Oct 2020 12:23:37 +0200, Kai-Heng Feng wrote: > @@ -1103,10 +1096,8 @@ static int azx_runtime_suspend(struct device *dev) > chip = card->private_data; > > /* enable controller wake up event */ > - if (snd_power_get_state(card) == SNDRV_CTL_POWER_D0) { > - azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) | > - STATESTS_INT_MASK); > - } > + azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) | > + STATESTS_INT_MASK);
Hrm, this doesn't look safe. Applying WAKEEN unconditionally means that the machine may get woken up from the system suspend, and we don't want that.
thanks,
Takashi
| |