Messages in this thread | | | Subject | Re: [PATCH v1 0/5] Introduce a new helper marco DEFINE_STORE_ATTRIBUTE at seq_file.c | From | luojiaxing <> | Date | Fri, 23 Oct 2020 14:29:05 +0800 |
| |
Hi
On 2020/10/22 20:28, Al Viro wrote: > On Thu, Oct 22, 2020 at 04:39:52PM +0800, Luo Jiaxing wrote: >> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute >> for read-only file, but we found many of drivers also want a helper marco for >> read-write file too. > DEFINE_SHOW_ATTRIBUTE is a bloody bad idea; let's not replicate the garbage > any further. If you want templates - C++ is over that way...
I am sorry but would you mind to explain it in more detail that why DEFINE_SHOW_ATTRIBUTE is a bad idea?
I found that DEFINE_SHOW_ATTRIBUTE is convenient and avoids a lot of duplicate code When add some debugfs file for DFX.
Thanks
Jiaxing
> > . >
| |