lkml.org 
[lkml]   [2020]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] PM: runtime: Resume the device earlier in __device_release_driver()
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    Since the device is resumed from runtime-suspend in
    __device_release_driver() anyway, it is better to do that before
    looking for busy managed device links from it to consumers, because
    if there are any, device_links_unbind_consumers() will be called
    and it will cause the consumer devices' drivers to unbind, so the
    consumer devices will be runtime-resumed. In turn, resuming each
    consumer device will cause the supplier to be resumed and when the
    runtime PM references from the given consumer to it are dropped, it
    may be suspended. Then, the runtime-resume of the next consumer
    will cause the supplier to resume again and so on.

    Update the code accordingly.

    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support")
    Cc: All applicable <stable@vger.kernel.org> # All applicable
    ---
    drivers/base/dd.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    Index: linux-pm/drivers/base/dd.c
    ===================================================================
    --- linux-pm.orig/drivers/base/dd.c
    +++ linux-pm/drivers/base/dd.c
    @@ -1117,6 +1117,8 @@ static void __device_release_driver(stru

    drv = dev->driver;
    if (drv) {
    + pm_runtime_get_sync(dev);
    +
    while (device_links_busy(dev)) {
    __device_driver_unlock(dev, parent);

    @@ -1132,8 +1134,6 @@ static void __device_release_driver(stru
    return;
    }

    - pm_runtime_get_sync(dev);
    -
    driver_sysfs_remove(dev);

    if (dev->bus)


    \
     
     \ /
      Last update: 2020-10-21 21:15    [W:3.474 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site