Messages in this thread | | | Subject | Re: [PATCH] bus: mhi: core: fix potential operator-precedence with BHI macros | From | Hemant Kumar <> | Date | Wed, 21 Oct 2020 09:33:04 -0700 |
| |
On 10/20/20 1:29 PM, Jeffrey Hugo wrote: > The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is > a BHI register index. If 'n' is an expression rather than a simple > value, there can be an operator precedence issue which can result > in the incorrect calculation of the register offset. Adding > parentheses around the macro parameter can prevent such issues. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |