Messages in this thread | | | Subject | Re: [RFC PATCH v3 6/9] ipu3-cio2: Rename ipu3-cio2.c to allow module to be built from multiple sources files retaining ipu3-cio2 name | From | Dan Scally <> | Date | Tue, 20 Oct 2020 21:41:48 +0100 |
| |
On 20/10/2020 10:15, Andy Shevchenko wrote: > On Mon, Oct 19, 2020 at 11:59:00PM +0100, Daniel Scally wrote: >> ipu3-cio2 driver needs extending with multiple files; rename the main >> source file and specify the renamed file in Makefile to accommodate that. > Suggested-by? Oops - yes of course, will add that next version. > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > after addressing below comment. > >> Signed-off-by: Daniel Scally <djrscally@gmail.com> >> --- >> Changes in v3: >> - patch introduced >> >> drivers/media/pci/intel/ipu3/Makefile | 2 ++ >> drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} | 0 >> 2 files changed, 2 insertions(+) >> rename drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} (100%) >> >> diff --git a/drivers/media/pci/intel/ipu3/Makefile b/drivers/media/pci/intel/ipu3/Makefile >> index 98ddd5bea..b4e3266d9 100644 >> --- a/drivers/media/pci/intel/ipu3/Makefile >> +++ b/drivers/media/pci/intel/ipu3/Makefile >> @@ -1,2 +1,4 @@ >> # SPDX-License-Identifier: GPL-2.0-only >> obj-$(CONFIG_VIDEO_IPU3_CIO2) += ipu3-cio2.o >> + >> +ipu3-cio2-y += ipu3-cio2-main.o >> \ No newline at end of file > Don't forget to add \n at the end of above line. > >> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c >> similarity index 100% >> rename from drivers/media/pci/intel/ipu3/ipu3-cio2.c >> rename to drivers/media/pci/intel/ipu3/ipu3-cio2-main.c >> -- >> 2.17.1 >>
| |