Messages in this thread | | | Date | Tue, 20 Oct 2020 13:29:13 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump |
| |
> > After brief evaluation it still doesn't look easy. The simplest thing > > I could imagine is to probably combine file_path and file_offset at a > > struct object on stack and then pass the object by the reference along > > function calls. I expect it will roughly cause the same amount of changes > > in the code and saves one argument (GP register). It is not that much > > but still. However I don't see issues with passing even 6 args on stack. > > Sorry - "passing 6 args to a function call"
Ah it wasn't about code efficiency, just maintainability. Function calls with too many arguments are generally hard to maintain, and typically at some point have to be refactored anyways because they tend to grow even more over time.
But if it's too difficult, ok.
-Andi
| |