Messages in this thread | | | Date | Tue, 20 Oct 2020 18:28:44 +0200 | From | Greg KH <> | Subject | Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available |
| |
On Tue, Oct 20, 2020 at 06:23:03PM +0200, Laurent Vivier wrote: > We can avoid to probe for the Zilog device (and generate ugly kernel warning) > if kernel is built for Mac but not on a Mac. > > Signed-off-by: Laurent Vivier <laurent@vivier.eu> > --- > drivers/tty/serial/pmac_zilog.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c > index 063484b22523..d1d2e55983c3 100644 > --- a/drivers/tty/serial/pmac_zilog.c > +++ b/drivers/tty/serial/pmac_zilog.c > @@ -1867,6 +1867,12 @@ static struct platform_driver pmz_driver = { > static int __init init_pmz(void) > { > int rc, i; > + > +#ifdef CONFIG_MAC > + if (!MACH_IS_MAC) > + return -ENODEV; > +#endif
Why is the #ifdef needed?
We don't like putting #ifdef in .c files for good reasons. Can you make the api check for this work with and without that #ifdef needed?
thanks,
greg k-h
| |