Messages in this thread | | | Subject | Re: [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller | From | Dafna Hirschfeld <> | Date | Tue, 20 Oct 2020 18:23:52 +0200 |
| |
Hi, thanks,
Am 20.10.20 um 16:46 schrieb Colin King: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the const array dev_names on the stack but instead it > static. Makes the object code smaller by 15 bytes. > > Before: > text data bss dec hex filename > 17091 2648 64 19803 4d5b media/rkisp1/rkisp1-resizer.o > > After: > text data bss dec hex filename > 17012 2712 64 19788 4d4c media/rkisp1/rkisp1-resizer.o
On the other hand the data segment is 64 bytes bigger. I don't know what is more important to save. Anyway, the rkisp1-capture.c does the same with the names so it is better to be consistent.
Thanks, Dafna
> > (gcc version 10.2.0) > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/staging/media/rkisp1/rkisp1-resizer.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c > index 1687d82e6c68..7ca5b47c5bf5 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c > +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c > @@ -763,8 +763,10 @@ static void rkisp1_rsz_unregister(struct rkisp1_resizer *rsz) > > static int rkisp1_rsz_register(struct rkisp1_resizer *rsz) > { > - const char * const dev_names[] = {RKISP1_RSZ_MP_DEV_NAME, > - RKISP1_RSZ_SP_DEV_NAME}; > + static const char * const dev_names[] = { > + RKISP1_RSZ_MP_DEV_NAME, > + RKISP1_RSZ_SP_DEV_NAME > + }; > struct media_pad *pads = rsz->pads; > struct v4l2_subdev *sd = &rsz->sd; > int ret; >
| |