Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH] arm64: meson: ship only the necessary clock controllers | Date | Tue, 20 Oct 2020 08:03:16 -0700 |
| |
Jerome Brunet <jbrunet@baylibre.com> writes:
> There now the menu entries for the amlogic clock controllers. > Do not select these when ARM64 is enabled so it possible to ship only the > required. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > arch/arm64/Kconfig.platforms | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index cd58f8495c45..b22d1bdd6eb6 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -154,9 +154,6 @@ config ARCH_MESON > bool "Amlogic Platforms" > select PINCTRL > select PINCTRL_MESON > - select COMMON_CLK_GXBB > - select COMMON_CLK_AXG > - select COMMON_CLK_G12A
This patch alone will break boot when using the default, upstream defconfig because these options will all now be disabled and we'll have no clock providers.
I think you also need a default value (e.g. `default y`) in drivers/clk/meson/Kconfig for each of these entries to keep the same defaults. But these defaults could be overridden by SoC-specific defconfigs leading to more flexibilty.
So, assuming you queue up a drivers/clk patch to go in when this lands...
Acked-by: Kevin Hilman <khilman@baylibre.com>
| |