Messages in this thread | | | Date | Tue, 20 Oct 2020 15:06:15 +0300 | From | Sakari Ailus <> | Subject | Re: [RFC PATCH v3 7/9] ipu3-cio2: Check if pci_dev->dev's fwnode is a software_node in cio2_parse_firmware() and set FWNODE_GRAPH_DEVICE_DISABLED if so |
| |
Hi Andy,
On Tue, Oct 20, 2020 at 12:19:58PM +0300, Andy Shevchenko wrote: > On Mon, Oct 19, 2020 at 11:59:01PM +0100, Daniel Scally wrote: > > fwnode_graph_get_endpoint_by_id() will optionally parse enabled devices > > only; that status being determined through the .device_is_available() op > > of the device's fwnode. As software_nodes don't have that operation and > > adding it is meaningless, we instead need to check if the device's fwnode > > is a software_node and if so pass the appropriate flag to disable that > > check > > Period. > > I'm wondering if actually this can be hidden in fwnode_graph_get_endpoint_by_id().
The device availability test is actually there for a reason. Some firmware implementations put all the potential devices in the tables and only one (of some) of them are available.
Could this be implemented so that if the node is a software node, then get its parent and then see if that is available?
I guess that could be implemented in software node ops. Any opinions?
-- Kind regards,
Sakari Ailus
| |