Messages in this thread | | | Date | Tue, 20 Oct 2020 13:08:10 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] power: suspend: Replace dpm_watchdog by sleep timer |
| |
On Tue, Oct 20, 2020 at 05:56:11PM +0800, Joseph Jang wrote: > Since dpm_watchdog just cover device power management, > we proposed sleep timer to cover not only device power management > issues, but also core power management hand issue. > > Add sleep timer and timeout handler to prevent device stuck during suspend/ > resume process. The timeout handler will dump disk sleep task at first > round timeout and trigger kernel panic at second round timeout. > The default timer for each round is defined in > CONFIG_PM_SLEEP_TIMER_TIMEOUT. > > Signed-off-by: Joseph Jang <josephjang@google.com> > --- > drivers/base/power/main.c | 69 --------------------------- > include/linux/console.h | 1 + > kernel/power/Kconfig | 27 ++++++----- > kernel/power/suspend.c | 19 ++++++++ > kernel/power/suspend_timer.h | 90 ++++++++++++++++++++++++++++++++++++ > kernel/printk/printk.c | 5 ++ > 6 files changed, 128 insertions(+), 83 deletions(-) > create mode 100644 kernel/power/suspend_timer.h
Is this different from your previous patches?
If so, you need to properly version them, and put below the --- line what changed. Otherwise it is impossible to review.
Please fix up.
thanks,
greg k-h
| |