lkml.org 
[lkml]   [2020]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3 1/9] software_node: Add helper function to unregister arrays of software_nodes ordered parent to child
On Tue, Oct 20, 2020 at 01:05:10PM +0300, Sakari Ailus wrote:
> On Mon, Oct 19, 2020 at 11:58:55PM +0100, Daniel Scally wrote:
> > Software nodes that are children of another software node should be
> > unregistered before their parent. To allow easy unregistering of an array
> > of software_nodes ordered parent to child, add a helper function to loop
> > over and unregister nodes in such an array in reverse order.

...

> > + * software_node_unregister_nodes_reverse - Unregister an array of software
> > + * nodes in reverse order.
> > + * @nodes: Array of software nodes to be unregistered.
> > + *
> > + * NOTE: The same warning applies as with software_node_unregister_nodes.
> > + * Unless you are _sure_ that the array of nodes is ordered parent to child
> > + * it is wiser to remove them individually in the correct order.
>
> Could the default order in software_node_unregister_nodes() be reversed
> instead? There are no users so this should be easy to change.
>
> Doing this only one way may require enforcing the registration order in
> software_node_register_nodes(), but the end result would be safer.
>
> What do you think?

Will work for me (I would also hear Heikki).

But in such case let's change the order of
software_node_unregister_node_group() for the sake of consistency.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-10-20 13:02    [W:1.965 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site