lkml.org 
[lkml]   [2020]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/5] scsi: ufs: use WQ_HIGHPRI for gating work
On 2020-10-21 03:52, Jaegeuk Kim wrote:
> From: Jaegeuk Kim <jaegeuk@google.com>
>
> Must have WQ_MEM_RECLAIM
> ``WQ_MEM_RECLAIM``
> All wq which might be used in the memory reclaim paths **MUST**
> have this flag set. The wq is guaranteed to have at least one
> execution context regardless of memory pressure.
>

You misunderstood my point. I meant you need to give more info about why
we are adding WQ_HIGHPRI flag but not why WQ_MEM_RECLAIM must be there.

Thanks,

Can Guo.

> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Avri Altman <avri.altman@wdc.com>
> Cc: Can Guo <cang@codeaurora.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index feb10ebf7a35..0858c0b55eac 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1867,7 +1867,7 @@ static void ufshcd_init_clk_gating(struct ufs_hba
> *hba)
> snprintf(wq_name, ARRAY_SIZE(wq_name), "ufs_clk_gating_%d",
> hba->host->host_no);
> hba->clk_gating.clk_gating_workq = alloc_ordered_workqueue(wq_name,
> - WQ_MEM_RECLAIM);
> + WQ_MEM_RECLAIM | WQ_HIGHPRI);
>
> hba->clk_gating.is_enabled = true;

\
 
 \ /
  Last update: 2020-10-21 02:59    [W:0.088 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site