Messages in this thread | | | Subject | Re: [PATCH v3] cpupower: Provide online and offline CPU information | From | Shuah Khan <> | Date | Tue, 20 Oct 2020 18:30:57 -0600 |
| |
On 10/16/20 2:59 AM, Brahadambal Srinivasan wrote: > When a user tries to modify cpuidle or cpufreq properties on offline > CPUs, the tool returns success (exit status 0) but also does not provide > any warning message regarding offline cpus that may have been specified > but left unchanged. In case of all or a few CPUs being offline, it can be > difficult to keep track of which CPUs didn't get the new frequency or idle > state set. Silent failures are difficult to keep track of when there are a > huge number of CPUs on which the action is performed. >
This fllowing text shouldn't be part of the change log. This type of version to version change text is added between the --- and start of diff.
> In v1 of this patch, I had sent tried to address this with repetitive code > in both cpufreq-set and cpuidle-set. V2 incorporated the review comments > and added helper functions to find both online and offline CPUs and print > them out accordingly. Correcting compile issues in v3. > > We use these helper functions in cpuidle-set and cpufreq-set to print an > additional message if the user attempts to modify offline cpus. > > Reported-by: Pavithra R. Prakash <pavrampu@in.ibm.com> > Signed-off-by: Brahadambal Srinivasan <latha@linux.vnet.ibm.com> > --- > tools/power/cpupower/utils/cpufreq-set.c | 3 + > tools/power/cpupower/utils/cpuidle-set.c | 4 ++ > tools/power/cpupower/utils/cpupower.c | 8 +++ > tools/power/cpupower/utils/helpers/helpers.h | 12 ++++ > tools/power/cpupower/utils/helpers/misc.c | 66 +++++++++++++++++++- > 5 files changed, 92 insertions(+), 1 deletion(-) >
Add revision changes here.
> diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c > index 6ed82fba5aaa..f25cdfa05c5f 100644 > --- a/tools/power/cpupower/utils/cpufreq-set.c > +++ b/tools/power/cpupower/utils/cpufreq-set.c
thanks, -- Shuah
| |