Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi" | From | Stephen Boyd <> | Date | Fri, 02 Oct 2020 10:48:32 -0700 |
| |
Quoting Mark Brown (2020-10-02 09:03:24) > On Thu, Oct 01, 2020 at 05:45:00PM -0700, David Collins wrote: > > > The SPMI regmap debugfs files are used extensively for testing and debug > > purposes internally at Qualcomm and by our customers. It would be helpful > > if the more verbose naming scheme were accepted upstream to avoid > > confusion and broken test scripts. > > ...and doing this in the dev_name() should help other diagnostic users > (like dev_printk() for example).
Don't thinks like dev_printk() prefix the bus name? See dev_driver_string()? So I agree that having the bus name is useful, but confused why there are testing scripts and things on top of regmap debugfs
Put another way, why not introduce something similar to i2c-dev where userspace can read/write registers for devices on the SPMI bus? Otherwise I presume the test scripts inside Qualcomm are just reading registers out of regmap?
| ![\](/images/icornerr.gif) |