Messages in this thread | | | Date | Fri, 2 Oct 2020 17:22:19 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH] random32: Restore __latent_entropy attribute on net_rand_state |
| |
On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote: > From: Thibaut Sautereau <thibaut.sautereau@ssi.gouv.fr> > > Commit f227e3ec3b5c ("random32: update the net random state on interrupt > and activity") broke compilation and was temporarily fixed by Linus in > 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy > gcc plugin") by entirely moving net_rand_state out of the things handled > by the latent_entropy GCC plugin. > > From what I understand when reading the plugin code, using the > __latent_entropy attribute on a declaration was the wrong part and > simply keeping the __latent_entropy attribute on the variable definition > was the correct fix.
Ah thank you, this is what I tried to figure and failed to! Spender mentioned that a one-liner was all that was needed to fix this but never responded to my request asking about it.
Willy
| |