Messages in this thread | | | Date | Fri, 2 Oct 2020 14:00:08 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH] locking/atomics: Check atomic-arch-fallback.h too |
| |
On Thu, Oct 01, 2020 at 10:20:28PM +0200, Paul Bolle wrote: > The sha1sum of include/linux/atomic-arch-fallback.h isn't checked by > check-atomics.sh. It's not clear why it's skipped so let's check it too. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
This was an oversight; Peter and I forgot to add this when Peter added the arch fallbacks in commit:
37f8173dd84936ea ("locking/atomics: Flip fallbacks and instrumentation")
... for which we could arguably add a fixes tag.
Either way:
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Peter, I assume you'll pick this up (and also that the hash is up-to-date as it should be).
> --- > It seems it never has been checked. So this does cast some doubt about > the usefulness of these tests. But I'm clueless about this atomic stuff > so what do I know?
The tests have been useful to ensure people fixed up the scripts when altering other files, so I think it makes sense to keep this even if we did miss one file recently.
Mark.
> > scripts/atomic/check-atomics.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/atomic/check-atomics.sh b/scripts/atomic/check-atomics.sh > index 8378c63a1e09..82748d42ecc5 100755 > --- a/scripts/atomic/check-atomics.sh > +++ b/scripts/atomic/check-atomics.sh > @@ -16,6 +16,7 @@ fi > cat <<EOF | > asm-generic/atomic-instrumented.h > asm-generic/atomic-long.h > +linux/atomic-arch-fallback.h > linux/atomic-fallback.h > EOF > while read header; do > -- > 2.26.2 >
| |