Messages in this thread | | | Subject | Re: [PATCH -next] ASoC: qcom: fix SDM845 & QDSP6 dependencies more | From | Srinivas Kandagatla <> | Date | Fri, 2 Oct 2020 13:57:39 +0100 |
| |
On 01/10/2020 19:35, Randy Dunlap wrote: > Fix a build error and Kconfig warning in sound/soc/qcom/. > > ld: sound/soc/qcom/qdsp6/q6afe-clocks.o: in function `q6afe_clock_dev_probe': > q6afe-clocks.c:(.text+0x182): undefined reference to `devm_clk_hw_register' > ld: q6afe-clocks.c:(.text+0x19d): undefined reference to `of_clk_add_hw_provider' > > After adding "depends on COMMON_CLK" for SND_SOC_QDSP6, the Kconfig > warning appears because "select" does not honor any "depends on" > clauses, so fix the dependency for SND_SOC_SDM845 also. > > WARNING: unmet direct dependencies detected for SND_SOC_QDSP6 > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n] > Selected by [y]: > - SND_SOC_SDM845 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && I2C [=y] && SOUNDWIRE [=y] > > Fixes: 520a1c396d19 ("ASoC: q6afe-clocks: add q6afe clock controller") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.com> > Cc: alsa-devel@alsa-project.org
Thanks Randy for fixing this!
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini > --- > sound/soc/qcom/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20201001.orig/sound/soc/qcom/Kconfig > +++ linux-next-20201001/sound/soc/qcom/Kconfig > @@ -82,6 +82,7 @@ config SND_SOC_QDSP6_ASM_DAI > config SND_SOC_QDSP6 > tristate "SoC ALSA audio driver for QDSP6" > depends on QCOM_APR > + depends on COMMON_CLK > select SND_SOC_QDSP6_COMMON > select SND_SOC_QDSP6_CORE > select SND_SOC_QDSP6_AFE > @@ -110,6 +111,7 @@ config SND_SOC_MSM8996 > config SND_SOC_SDM845 > tristate "SoC Machine driver for SDM845 boards" > depends on QCOM_APR && I2C && SOUNDWIRE > + depends on COMMON_CLK > select SND_SOC_QDSP6 > select SND_SOC_QCOM_COMMON > select SND_SOC_RT5663 >
| |